Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.19] Update configuration section in docs #8087

Merged
merged 1 commit into from
May 1, 2024
Merged

[release-0.19] Update configuration section in docs #8087

merged 1 commit into from
May 1, 2024

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #8076

/assign sp1999

@eks-distro-pr-bot eks-distro-pr-bot mentioned this pull request May 1, 2024
Merged
@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 1, 2024
@sp1999
Copy link
Member

sp1999 commented May 1, 2024

/ok-to-test

@codecov Codecov
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-0.19@53b8927). Click here to learn what that means.

Additional details and impacted files 
@@               Coverage Diff               @@
##             release-0.19    #8087   +/-   ##
===============================================
  Coverage                ?   73.53%           
===============================================
  Files                   ?      588           
  Lines                   ?    37186           
  Branches                ?        0           
===============================================
  Hits                    ?    27344           
  Misses                  ?     8049           
  Partials                ?     1793

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member

sp1999 commented May 1, 2024

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp1999 sp1999 merged commit daa8634 into aws:release-0.19 May 1, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sp1999 sp1999

Labels
approved area/docs Documentation documentation lgtm ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eks-distro-pr-bot @eks-distro-bot @sp1999